PR for #1474: Update high resoultion media query #1691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,6 @@ | |||
| * Update high resoultion media query | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This commit adds a the dppx variant of min-resolution to add an easier to use value for the media query. `dppx` is not supported by all browsers and needs the `dpi` fallblack. `dppx` is more acurate than `dpi` since dots per inch refers to a defined size of pixels wher one inch is 96px what so ever and does not take physical inches into account. Autoprefixer will include `-webkit-min-device-pixel-ratio` which is needed for Safari and WebKit devices. Reference #1474.
| @@ -1,3 +1,6 @@ | |||
| * Update high resolution media query | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
eleanor-byhook
pushed a commit
to eleanor-byhook/html5-boilerplate
that referenced
this pull request
Feb 29, 2016
Add `dppx` variant of `min-resolution` to the high resolution media query as `dppx` is more accurate¹ than `dpi`. Notes: * since `dppx` is not supported by all browsers the media query still needs the `dpi` fallback * this change removes the `dppx` related warning² from Blink based browsers (e.g.: Chrome, Opera) - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ¹ `dpi` (dots per inch) refers to a defined size of pixels where one inch is `96px` no matter what, so it does not take into consideration the physical inches. ² "Consider using 'dppx' units, as in CSS 'dpi' means dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to the actual 'dpi' of a screen. In media query expression: print, (-webkit-min-device-pixel-ratio: 1.25), (min-resolution: 120dpi)" Fix h5bp/html5-boilerplate#1474 Close h5bp/html5-boilerplate#1691
jeffreznik
pushed a commit
to jeffreznik/sw-test
that referenced
this pull request
Oct 15, 2017
Add `dppx` variant of `min-resolution` to the high resolution media query as `dppx` is more accurate¹ than `dpi`. Notes: * since `dppx` is not supported by all browsers the media query still needs the `dpi` fallback * this change removes the `dppx` related warning² from Blink based browsers (e.g.: Chrome, Opera) - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ¹ `dpi` (dots per inch) refers to a defined size of pixels where one inch is `96px` no matter what, so it does not take into consideration the physical inches. ² "Consider using 'dppx' units, as in CSS 'dpi' means dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to the actual 'dpi' of a screen. In media query expression: print, (-webkit-min-device-pixel-ratio: 1.25), (min-resolution: 120dpi)" Fix h5bp#1474 Close h5bp#1691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR for #1474.
Please keep the discussion within #1474.